Skip to content

feat(signals): classify PDM, Conan, and Pixi lockfiles#2108

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
kiannidev:feat/signals-extra-lockfiles-pdm-conan-pixi
Jul 1, 2026
Merged

feat(signals): classify PDM, Conan, and Pixi lockfiles#2108
JSONbored merged 2 commits into
JSONbored:mainfrom
kiannidev:feat/signals-extra-lockfiles-pdm-conan-pixi

Conversation

@kiannidev

@kiannidev kiannidev commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Recognize pdm.lock, conan.lock, and pixi.lock in slop path matchers.

No-issue rationale

Extends lockfile classification (#561) with no linked issue.

Test plan

  • npx vitest run test/unit/path-matchers.test.ts

Made with Cursor

@kiannidev
kiannidev requested a review from JSONbored as a code owner July 1, 2026 09:08
@dosubot dosubot Bot added the size:XS label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.71%. Comparing base (859f8ef) to head (a3ca7ca).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2108   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         222      222           
  Lines       24655    24655           
  Branches     8946     8946           
=======================================
  Hits        23599    23599           
  Misses        433      433           
  Partials      623      623
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb

loopover-orb Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-01 17:55:26 UTC

2 files · 1 AI reviewer · no blockers · readiness 48/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change extends `LOCKFILE_NAMES` with PDM, Conan, and Pixi lockfiles, and the existing `classifyChangedFile` flow picks them up before manifest/config/source classification. The implementation is correct because `isLockfile` already normalizes case and compares only the basename, so these additions inherit the existing path behavior. The tests cover both direct lockfile matching and end-to-end changed-file classification for all three new names.

Nits — 3 non-blocking
  • nit: `test/unit/path-matchers.test.ts:73` adds only lowercase top-level examples for the new names even though the test title promises directory and case handling.
  • `test/unit/path-matchers.test.ts:73` could use one nested or mixed-case new example, such as `tools/Conan.lock`, to keep the stated coverage shape aligned with the new cases.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 2694 registered-repo PR(s), 1487 merged, 48 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 2694 PR(s), 48 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, C++, HTML, MDX, Rust
  • Official Gittensor activity: 2694 PR(s), 48 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (PR #2122, PR #2392)
  • Related work: Titles/paths share 6 meaningful terms. (PR #2122, PR #2389)
  • Related work: Titles/paths share 6 meaningful terms. (PR #2392, PR #2389)
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 1, 2026
@kiannidev
kiannidev force-pushed the feat/signals-extra-lockfiles-pdm-conan-pixi branch from 0fbeb21 to 48d804e Compare July 1, 2026 12:15
kiannidev and others added 2 commits July 1, 2026 14:26
@kiannidev @cursoragent
feat(signals): classify PDM, Conan, and Pixi lockfiles
276bf96 
Recognize pdm.lock, conan.lock, and pixi.lock so slop path classifiers
weight Python and C++ dependency lock churn separately from source.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev @cursoragent
test(signals): cover PDM, Conan, and Pixi lockfile classification cases
a3ca7ca 
Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev force-pushed the feat/signals-extra-lockfiles-pdm-conan-pixi branch from 48d804e to a3ca7ca Compare July 1, 2026 12:26
@dosubot dosubot Bot added the lgtm label Jul 1, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 1, 2026
@JSONbored
JSONbored merged commit 8b0ac26 into JSONbored:main Jul 1, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSONbored JSONbored JSONbored approved these changes

Assignees

@kiannidev kiannidev

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
gittensory - v1 roadmap
Status: Done

Milestone

REES analyzer runtime (epic #1499)

Development

Successfully merging this pull request may close these issues.

2 participants

@kiannidev @JSONbored